vitess icon indicating copy to clipboard operation
vitess copied to clipboard

[DNM] mysql restart - query list override issue

Open harshit-gangal opened this issue 2 years ago • 1 comments

Signed-off-by: Harshit Gangal [email protected]

Description

Related Issue(s)

Checklist

  • [ ] "Backport me!" label has been added if this change should be backported
  • [ ] Tests were added or are not required
  • [ ] Documentation was added or is not required

Deployment Notes

harshit-gangal avatar Sep 21 '22 17:09 harshit-gangal

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • [ ] Is it really necessary to add this flag?
  • [ ] Flag names should be clear and intuitive (as far as possible)
  • [ ] Help text should be descriptive.
  • [ ] Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • [ ] Each item in Jobs should be named in order to mark it as required.
  • [ ] If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • [ ] There should be at least one unit or end-to-end test.
  • [ ] The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • [ ] There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • [ ] Should be documented, either by modifying the existing documentation or creating new documentation.
  • [ ] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] vtctl command output order should be stable and awk-able.
  • [ ] RPC changes should be compatible with vitess-operator
  • [ ] If a flag is removed, then it should also be removed from VTop, if used there.

vitess-bot[bot] avatar Sep 21 '22 17:09 vitess-bot[bot]

We are in the in-between state right now where release-15.0 branch has been created but is not yet open for back ports (until rc1 is released). When that opens up, we'll need to manually port this fix for release 15.

deepthi avatar Oct 04 '22 16:10 deepthi