[VTAdmin] RebuildKeyspaceGraph, RemoveKeyspaceCell, NewShard

[notfelineit]

Signed-off-by: notfelineit [email protected]

Description

This PR implements the following "keyspace" actions:

• RebuildKeyspaceGraph
• CreateShard
• RemoveKeyspaceShard

It implements the portion from UI to VTAdmin API, calling the already implemented vtctldclient method.

Rebuild/Remove

Change

Related Issue(s)

• https://github.com/vitessio/vitess/issues/8739
• https://github.com/vitessio/vitess/issues/8736
• https://github.com/vitessio/vitess/issues/8740

Checklist

• [ ] "Backport me!" label has been added if this change should be backported
• [ ] Tests were added or are not required
• [ ] Documentation was added or is not required

Deployment Notes

[vitess-bot[bot]]

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

• [x] Ensure that the Pull Request has a descriptive title.
• [ ] If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
• [ ] If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

• [ ] There should be at least one unit or end-to-end test.
• [x] The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

• [ ] There should be some code comments as to why things are implemented the way they are.

New/Existing features

• [ ] Should be documented, either by modifying the existing documentation or creating new documentation.
• [ ] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• [ ] Protobuf changes should be wire-compatible.
• [ ] Changes to _vt tables and RPCs need to be backward compatible.
• [ ] vtctl command output order should be stable and awk-able.

[deepthi]

@notfelineit I just noticed that DCO check is failing. You will need to squash all the commits and add a sign-off.

git commit -a -s

[notfelineit]

@deepthi I followed the instructions here: https://github.com/vitessio/vitess/pull/11249/checks?check_run_id=8457122971 and a bunch of other commits were pulled in 😭

EDIT: I rebased off upstream again to fix the history!