vitess icon indicating copy to clipboard operation
vitess copied to clipboard

v14 backport of two PRs: vreplication throttling info & vreplication endtoend flakiness fix

Open shlomi-noach opened this issue 2 years ago • 3 comments

This PR backports to v14 both:

  • https://github.com/vitessio/vitess/pull/10601
  • https://github.com/vitessio/vitess/pull/10876

The intention was to just backport https://github.com/vitessio/vitess/pull/10876 to fix onlineddl_vrepl CI flakiness, but it then depends on #10601 so we're backporting that, too.

shlomi-noach avatar Aug 04 '22 06:08 shlomi-noach

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • [ ] If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • [ ] There should be at least one unit or end-to-end test.
  • [ ] The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • [ ] There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • [ ] Should be documented, either by modifying the existing documentation or creating new documentation.
  • [ ] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar Aug 04 '22 06:08 vitess-bot[bot]

Ironically onlineddl_vrepl fails.

shlomi-noach avatar Aug 04 '22 07:08 shlomi-noach

#10601 is too big to back port to the release branch. we should back port as much of #10876 as we can, OR find an alternative way to fix the flakiness.

deepthi avatar Aug 06 '22 00:08 deepthi

We;re good test-wise.

shlomi-noach avatar Aug 15 '22 08:08 shlomi-noach

We;re good test-wise.

Meaning we can close this without merging?

deepthi avatar Aug 16 '22 20:08 deepthi

Meaning we can close this without merging?

Sorry, missed this comment. No - meaning the tests for this PR are green ad fixed. This PR should be merged.

shlomi-noach avatar Aug 29 '22 15:08 shlomi-noach