vitess icon indicating copy to clipboard operation
vitess copied to clipboard

[mysqlctl] Rewrite CLI to cobra

Open ajm188 opened this issue 3 years ago • 2 comments

Description

This expands on the work in #10619, rewriting the mysqlctl command with all its subcommands to use spf13/cobra.

Testing

Starting the local example initial cluster, which invokes mysqlctl

Related Issue(s)

TK

Checklist

  • [ ] "Backport me!" label has been added if this change should be backported
  • [ ] Tests were added or are not required
  • [ ] Documentation was added or is not required

Deployment Notes

ajm188 avatar Jul 15 '22 22:07 ajm188

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

  • [ ] Ensure that the Pull Request has a descriptive title.
  • [ ] If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • [ ] If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • [ ] There should be at least one unit or end-to-end test.
  • [ ] The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • [ ] There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • [ ] Should be documented, either by modifying the existing documentation or creating new documentation.
  • [ ] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • [ ] Protobuf changes should be wire-compatible.
  • [ ] Changes to _vt tables and RPCs need to be backward compatible.
  • [ ] vtctl command output order should be stable and awk-able.

vitess-bot[bot] avatar Jul 15 '22 22:07 vitess-bot[bot]

Looking at the test failures here, I think we need to wait one more release before switching to cobra. (pflag works with our -- hack, but cobra is trying to be too smart).

So this will go in v16, and v15 will contain just the transition from flag.Parse to pflag.Parse.

ajm188 avatar Jul 17 '22 10:07 ajm188

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions[bot] avatar Sep 08 '22 01:09 github-actions[bot]

This PR was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar Sep 15 '22 01:09 github-actions[bot]