arewefastyet icon indicating copy to clipboard operation
arewefastyet copied to clipboard

Arewemobileyet: make this site mobile responsive

Open Maniktherana opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Currently, this site isn't mobile responsive. Accommodating mobile screens is a must on all websites. Critical information may be hidden when viewing from smaller viewports.

imageimage Describe the solution you'd like This will involve adding media queries and possibly separate, mobile-only components such as a mobile navbar.

Maniktherana avatar Jan 23 '24 13:01 Maniktherana

Hello @Maniktherana, thank you for opening this issue. Our previous LFX intern @marsian83 worked on https://github.com/vitessio/arewefastyet/pull/469 which is still unmerged to this day and which I believe is fixing some of the responsive issues you are seeing. You are welcome to continue on his PR or open a separate PR to fix the responsiveness 🙏🏻

frouioui avatar Jan 23 '24 17:01 frouioui

Hi @Maniktherana, you may check the responsiveness in #469 The PR has not yet been merged as some minor changes are to be made still But you may check if there are any missing portions of responsive behavior in that PR's head

marsian83 avatar Jan 23 '24 17:01 marsian83

@marsian83 Ah didnt realize, I'll check it out

Maniktherana avatar Jan 23 '24 17:01 Maniktherana

this has been fixed/implemented by @Jad31

frouioui avatar Jul 30 '24 09:07 frouioui