Admin UI and minor fixes

[marsian83]

Marked as draft for now

[marsian83]

@frouioui please review, I have added client side functionality for request and delete from queue

[frouioui]

Hey @marsian83 thank you for this Pull Request.

[codingmickey]

Hey @frouioui @marsian83 does this need any help, I'd be happy to take this up and bring it to at least a completion!

[frouioui]

@codingmickey Hello! I don't think @marsian83 has planned on continuing this given there was no response for months. You're welcome to take this on!

[marsian83]

Hey @frouioui @marsian83 does this need any help, I'd be happy to take this up and bring it to at least a completion!

Hi, it'd be great if you could honestly. The majority of the issues currently are due to mismatch of the type declarations we have on the frontend side vs the responses we recieve from the server. I'd recommend a straigh forward approach of checking the response types for the api calls in the errored pages and changing around the types accordingly. If you need any help understanding anything do let me know.

[marsian83]

Hi @codingmickey I see there are a lot of conflicts with the current state of the HEAD and the main let me resolve these conflicts first before you could look into this Mind waiting a day or two?

[codingmickey]

Sure anyways I have viva exam today and on Monday 😅

On Fri, 10 May, 2024, 10:46 pm Spandan Barve, @.***> wrote:

Hi @codingmickey https://github.com/codingmickey I see there are a lot of conflicts with the current state of the HEAD and the main let me resolve these conflicts first before you could look into this Mind waiting a day or two?

— Reply to this email directly, view it on GitHub https://github.com/vitessio/arewefastyet/pull/469#issuecomment-2104983221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEMS6Y3PN2PTS3W5XEA4R3ZBT6H3AVCNFSM6AAAAAA6MSXZQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHE4DGMRSGE . You are receiving this because you were mentioned.Message ID: @.***>

[harry-sandhu]

Hi, I made progress for this I fix some pages, where api had changed so I changed the api.ts file and fixed the rendering methods where the api response was being used But I did that on @marsian83, your fork's head but I can not push

@frouioui @marsian83 Can you please guide me aroudn this github issue?

[marsian83]

Hi, I made progress for this I fix some pages, where api had changed so I changed the api.ts file and fixed the rendering methods where the api response was being used But I did that on @marsian83, your fork's head but I can not push

@frouioui @marsian83 Can you please guide me aroudn this github issue?

You can fork my branch and then create PR to it, when I merge those, it will be added here. have you already made commits?

[harry-sandhu]

I have fixed all pages Daily page is not working, the endpoint returns null the endpoint /api/daily even the production version https://benchmark.vitess.io/api/daily returns null Please help me with this @frouioui @Camillemtd @marsian83
Also, I request you to test and review .Thanks

[marsian83]

I have reviewed your code @harry-sandhu Testing seems to indicate all pages work fine, except of course the daily page. I will see what can be wrong with the /api/daily endpoint

[frouioui]

I will close this as @Jad31 is going to do the admin UI again.