vite icon indicating copy to clipboard operation
vite copied to clipboard

feat(css): add cssExtract option to build config (#4345)

Open JackFGreen opened this issue 2 years ago • 5 comments

Description

Add cssExtract option.
When building as a library, you can also set this to false to avoid your users having to import the CSS themselves, like vue-cli css.extract

fix #4345


What is the purpose of this pull request?

  • [ ] Bug fix
  • [x] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Read the Pull Request Guidelines and follow the Commit Convention.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [x] Ideally, include relevant tests that fail without this PR but pass with it.

JackFGreen avatar Jan 20 '22 12:01 JackFGreen

I published this in my fork: @djaler/[email protected]

Djaler avatar Mar 09 '22 08:03 Djaler

Looks there are failing tests before it can be reviewed.

bluwy avatar Mar 09 '22 08:03 bluwy

@JackFGreen can you update this?

Djaler avatar Jun 13 '22 13:06 Djaler

@JackFGreen can you update this?

@Djaler updated, check the new version

JackFGreen avatar Jun 13 '22 16:06 JackFGreen

@JackFGreen there's a failed test that might require your attention

seahindeniz avatar Jul 27 '22 16:07 seahindeniz