vite icon indicating copy to clipboard operation
vite copied to clipboard

Guide says "at least 2.5 years ago" but means "at most 2.5 years ago"

Open mstange opened this issue 1 month ago • 7 comments

Documentation is

  • [ ] Missing
  • [ ] Outdated
  • [x] Confusing
  • [ ] Not sure?

Explain in Detail

https://github.com/vitejs/vite/blob/46d3077f2b63771cc50230bc907c48f5773c00fb/docs/guide/index.md?plain=1#L25

These are browsers that were released at least 2.5 years ago

I think the "at least" is backwards. A browser released 5 years ago is not what we mean here.

Your Suggestion for Changes

Maybe change it to "That means it only uses features which have been available across browsers for at least 2.5 years."

Reproduction

No response

Steps to reproduce

No response

mstange avatar Nov 23 '25 19:11 mstange

I think this is correct. The target is at least 2.5 years ago, because the target is fixed on each major release. It's currently around 3 years ago because the last major release was half a year ago.

sapphi-red avatar Nov 25 '25 02:11 sapphi-red

Hmm I see

mstange avatar Nov 25 '25 03:11 mstange

Maybe taking the Baseline docs, we can phrase it as this?

These browsers support common features that has been available for at least 2.5 years.

Also, this link seems handy: https://web-platform-dx.github.io/web-features/supported-browsers

bluwy avatar Nov 26 '25 08:11 bluwy

Maybe taking the Baseline docs, we can phrase it as this?

These browsers support common features that has been available for at least 2.5 years.

This is slightly incorrect. The current default browser target includes Chrome 107 which is released 2022-10-27 and may not support some of those features.

sapphi-red avatar Nov 26 '25 09:11 sapphi-red

Maybe we should word it similarly to how the dev browser support does?:

These code use features included in Baseline ~~Newly~~ Widely Available at the time of each major release (2025-05-01 for this major).

Also with a link to https://web-platform-dx.github.io/web-features/supported-browsers/?widelyAvailableOnDate=2025-05-01

sapphi-red avatar Nov 26 '25 09:11 sapphi-red

Sounds good to me.

These code use features...

Would it be more accurate to start with "These browsers support features..." since we're referring to the browser versions?

bluwy avatar Nov 27 '25 01:11 bluwy

I've submitted a PR to address this: #21165

hlongc avatar Nov 28 '25 13:11 hlongc