vite icon indicating copy to clipboard operation
vite copied to clipboard

fix(deps): update `open` dependency to 10.1.0

Open niklasmh opened this issue 1 year ago • 5 comments

Description

This is a fix for issue #14292 (converted to discussion #14293). I still get this error when running Vite in PowerShell (on Windows 10), which means the bug fix from the open dependency is not in Vite yet:

VITE v5.4.8  ready in 317 ms

  ➜  Local:   http://localhost:3001/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
Error: spawn undefined\System32\WindowsPowerShell\v1.0\powershell ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

In order to fix this, I upgraded the open package to 10.1.0 in packages/vite/package.json (the bug was fixed in version 10.0.1). I did not find any similar PRs to upgrade this package (not even in version v6.0.0-beta.2), so I made this.

The only breaking change going from ^8.4.2 to ^10.1.0 is that node should be >=18. Vite also requires node>=18, so this should not break anything.

niklasmh avatar Oct 14 '24 11:10 niklasmh

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

I am not sure how to update the pnpm-lock.yaml file properly using StackBlitz. I tried doing the minimal changes manually since the pnpm on StackBlitz enforces me to change the format of the lock file adding too many changes.

niklasmh avatar Oct 14 '24 11:10 niklasmh

We didn't update in the past due to increased package size (https://github.com/vitejs/vite/pull/15421), but seems like recently it shrunk down so we could probably upgrade it again now.

  • https://packagephobia.com/result?p=open
  • https://packagephobia.com/result?p=default-browser

bluwy avatar Oct 14 '24 12:10 bluwy

We didn't update in the past due to increased package size (#15421), but seems like recently it shrunk down so we could probably upgrade it again now.

  • https://packagephobia.com/result?p=open
  • https://packagephobia.com/result?p=default-browser

@bluwy Thanks for the explanation. That is good news. I tried fixing the issues in the lock file manually, but it seems like I don't have the right tools now. If anyone with the right setup could update the package that would be awesome.

niklasmh avatar Oct 14 '24 12:10 niklasmh

Seems like the dependencies are fixed now. I did another fix with how the Options type from the open package was imported that worked. Now the tests are failing. Not sure how to begin here.

niklasmh avatar Oct 14 '24 12:10 niklasmh