vite icon indicating copy to clipboard operation
vite copied to clipboard

Upgrade to chokidar v4

Open benmccann opened this issue 1 year ago • 2 comments

Description

Chokidar v4 is out now so can upgrade to it

Suggested solution

Should be done as part of a major since it's a bit breaking. Vite isn't using globs which were removed and disables them with disableGlobbing, but plugins can unfortunately hack around it like this

Alternative

No response

Additional context

Rollup will upgrade in 5.0: https://github.com/rollup/rollup/issues/5656#issuecomment-2357504813

Validations

benmccann avatar Sep 17 '24 14:09 benmccann

Vite isn't using globs which were removed

Vite supports glob in ignored option. https://github.com/vitejs/vite/blob/c1ed8a595a02ec7f8f5a8d23f97b2f21d3834ab1/packages/vite/src/node/watch.ts#L58-L64

sapphi-red avatar Sep 18 '24 01:09 sapphi-red

just a side note, glob is not directly supported by chokidar but they do mention that it's supported in other ways by reading glob from node:fs or node-glob see the Chokidar upgrading section for that

https://github.com/paulmillr/chokidar?tab=readme-ov-file#upgrading

ghiscoding avatar Sep 21 '24 05:09 ghiscoding