vite icon indicating copy to clipboard operation
vite copied to clipboard

feat(create-vite): add help usage

Open edvardsanta opened this issue 1 year ago • 1 comments

Description

closes #16374 image

edvardsanta avatar Apr 09 '24 22:04 edvardsanta

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Pushed a commit with some styling changes after discussing with other maintainers, here's how it looks now: image

The hardcoding isn't the most ideal, but I think it simplifies the code a lot and the templates aren't something we update often.

bluwy avatar Jun 13 '24 14:06 bluwy

Pushed a commit with some styling changes after discussing with other maintainers, here's how it looks now: image

The hardcoding isn't the most ideal, but I think it simplifies the code a lot and the templates aren't something we update often.

Wouldn't it be interesting to use the color properties in the Framework type? It would make the process more dynamic instead of manually creating them for each new framework.

Edit: It can be a technical debt. I will try to make some modifications in the future

edvardsanta avatar Jun 13 '24 15:06 edvardsanta

Yeah I did try that but to do so and others, it slows creeps in as a lot of code compared to hardcoding. So I leaned directly to the simplest way for now.

bluwy avatar Jun 13 '24 15:06 bluwy

Yeah I did try that but to do so and others, it slows creeps in as a lot of code compared to hardcoding. So I leaned directly to the simplest way for now.

I tried to make it more dynamic, but I forgot that we have four types of React, and the variants ended up looking strange. image

edvardsanta avatar Jun 13 '24 15:06 edvardsanta

Yeah that was also the part where I threw my hand and went for the simpler path instead 😄 It's hard to sort that one with a specific hardcoding too.

bluwy avatar Jun 13 '24 15:06 bluwy