fix(optimize-deps): don't externalize JS files imported with asset extensions

Open proc07 opened this issue 1 year ago • 4 comments

Description

fix #16116 importing a CommonJS module installed from NPM. The modue contains files with filenames like PeoplePicker.scss.js. These are JavaScript files, obviously, but the filename contains scss.

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Mar 23 '24 02:03 proc07

Run & review this pull request in StackBlitz Codeflow.

Mar 23 '24 02:03 bolt-new-by-stackblitz[bot]

Thanks. Would you add a test case in playground/optimize-deps?

sure, I'll add a test case

Mar 24 '24 07:03 proc07

@sapphi-red hi, I have submitted the test code, but how does the Actions check failing

Mar 24 '24 10:03 proc07

I guess you forgot to run pnpm i after adding a local package.

Mar 24 '24 10:03 sapphi-red