vite icon indicating copy to clipboard operation
vite copied to clipboard

refactor: remove acorn

Open sapphi-red opened this issue 1 year ago • 4 comments

Description

Rollup v4 doesn't use acorn and exposes parseAst. This PR removes acorn by using that function instead.

  • package size: 828.6 kB -> 772.2 kB
  • unpacked size: 3.6 MB -> 3.3MB

Additional context


What is the purpose of this pull request?

  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [x] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [x] Update the corresponding documentation if needed.
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

sapphi-red avatar Mar 22 '24 15:03 sapphi-red

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

/ecosystem-ci run

sapphi-red avatar Mar 23 '24 09:03 sapphi-red

The flaky CI fails is happening in main too. I'm investigating this and will submit a fix later. Merging this for now.

bluwy avatar May 29 '24 14:05 bluwy