vite icon indicating copy to clipboard operation
vite copied to clipboard

chore(deps): update postcss-load-config to v6

Open brc-dd opened this issue 2 years ago • 12 comments

Description

Bump postcss-load-config to v5. It added support for ESM + TS postcss configs (postcss/postcss-load-config#249). closes #15234 closes #15745 (and other issues that were closed/locked as they were upstream issues).

Additional context

It now needs jiti instead of ts-node for TS config files in Node.js. Might be a slightly breaking change for users?


What is the purpose of this pull request?

  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [x] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [x] Update the corresponding documentation if needed.
  • [x] Ideally, include relevant tests that fail without this PR but pass with it.

brc-dd avatar Dec 04 '23 01:12 brc-dd

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Yeah I think this is a breaking change and we can't bump this until v6. Unless we can still get ts-node working partially, but it doesn't seem likely now with postcss-load-config cutting a major.

Also for future reference, the renovate PR: https://github.com/vitejs/vite/pull/15234

bluwy avatar Dec 04 '23 06:12 bluwy

Hi guys,

Is there something blocking this PR to be part of final 6.0?

kuchta avatar Apr 06 '24 23:04 kuchta

@kuchta the PR is already in the v6 milestone. Would you comment on your use case so your comment gives value to this PR?

patak-dev avatar Apr 08 '24 07:04 patak-dev

@patak-dev Well, it's not part of the v6 alpha release, so I'm curious... My use case is using postcss.config.ts

kuchta avatar Apr 08 '24 07:04 kuchta

@kuchta I see. We're going to use the v6 alpha series to let the ecosystem test the Environment API branch. See:

  • https://github.com/vitejs/vite/discussions/16358

patak-dev avatar Apr 08 '24 08:04 patak-dev

For information I sent this PR to reduce bundle size: https://github.com/postcss/postcss-load-config/pull/261

ArnaudBarre avatar May 23 '24 23:05 ArnaudBarre