vite-plugin-vue icon indicating copy to clipboard operation
vite-plugin-vue copied to clipboard

fix: use href carry no-inline query

Open btea opened this issue 1 year ago • 5 comments

Description

fix #490

Additional context


What is the purpose of this pull request?

  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [ ] Read the Contributing Guidelines.
  • [ ] Read the Pull Request Guidelines and follow the PR Title Convention.
  • [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

btea avatar Dec 16 '24 06:12 btea

Open in Stackblitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@491
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@491

commit: e7345e2

pkg-pr-new[bot] avatar Dec 16 '24 06:12 pkg-pr-new[bot]

I think instead of adding ?no-inline automatically, we need to tell @vue/compiler-sfc not to strip the queries and hashes (not sure if @vue/compiler-sfc is doing that). Otherwise, <img src="./foo.svg?inline"> or <img src="./foo.png?no-inline"> won't work as users expect.

sapphi-red avatar Dec 17 '24 02:12 sapphi-red

No relevant configuration is found.

btea avatar Dec 17 '24 13:12 btea

I haven't been able to find the relevant configuration.

Currently, it will only add ?no-inline to the href attribute of the use tag(it seems that only the use tag cannot directly load the data URIs link), which should not affect the processing of the img tag.

I haven't been able to find a better way, and would appreciate your suggestions.

btea avatar Dec 20 '24 03:12 btea

Adding ?no-inline automatically for <use> in plugin-vue makes sense to me.

That said, if there isn't an option in @vue/compiler-sfc, I think that needs to be added to support other cases.

sapphi-red avatar Dec 24 '24 02:12 sapphi-red