ember-cli-webfont icon indicating copy to clipboard operation
ember-cli-webfont copied to clipboard

Update `ember-cli-babel` to version 7

Open boris-petrov opened this issue 3 years ago • 6 comments

This is the only plugin that I use that still uses ember-cli-babel 6 so I decided to update it. Not sure if this is enough or more changes are needed to the plugin?

cc @vitch

boris-petrov avatar Mar 04 '21 19:03 boris-petrov

Honestly I haven't used this plugin in many years. If you are using it and it still works for you with this change I'm happy to merge and release...

vitch avatar Mar 04 '21 21:03 vitch

Although it looks like Travis is unhappy because:

The command "eval yarn --frozen-lockfile " failed.

vitch avatar Mar 04 '21 21:03 vitch

I was just trying to figure that out. Any ideas what that is and why it fails?

boris-petrov avatar Mar 04 '21 21:03 boris-petrov

Actually - I think the real error is:

The engine "node" is incompatible with this module. Expected version "8.* || 10.* || >= 12.*"

I set my node and yarn versions to the same as TravisCI via volta (6.17.1 and 1.3.2 respectively) and got the same error.

Maybe you can update node_js: in the travis.yml too?

vitch avatar Mar 04 '21 21:03 vitch

Done. But this means a new major version. And while we're at it, we could do other version updates I guess?

boris-petrov avatar Mar 04 '21 21:03 boris-petrov

@vitch - this is ready for merging. I moved a few things around and updated the used webfonts-generator library. The Node requirement had to be updated to version 12 because of ttf2woff2 - here is a failing Travis build for proof.

I tried out the branch, it seems to work great. So a new (major) release will be appreciated! :) Thanks!

boris-petrov avatar Jun 01 '21 06:06 boris-petrov