django-ninja
django-ninja copied to clipboard
Distinguish between AuthenticationError and AuthorizationError
Implements #1218
As far as I'm concerned, this looks good, thx
Can we merge this soon? I also think it looks good and I need this distinction as well since I currently use django-ninja.
I think this might be done better...
AuthenticationError, AuthorizationError should be both inherited from HttpError (with corresponding codes and messages)
that way only one default http-error handler is needed (and users should be able to overwrite custom handlers for each class individualy)
I think this might be done better...
AuthenticationError,AuthorizationErrorshould be both inherited from HttpError (with corresponding codes and messages)that way only one default http-error handler is needed (and users should be able to overwrite custom handlers for each class individualy)
Didn't want to cause too much changes with this PR, but definitely the way to go
Hi, thanks for the updates. When are you guys expecting these changes? Release 1.3.0 doesn't contain AFAIK? Please, correct me if I am wrong. Thanks!
@NikolozCh you may check Django Shinobi, the community fork that is currently maintained The plan is to merge it back if possible, and if we have no news from @vitalik we will still make the framework more community oriented so the current situation doesn’t happen again
Thanks @c4ffein. Django Shinobi worked perfectly well.