django-ninja icon indicating copy to clipboard operation
django-ninja copied to clipboard

Add union type and subtypes check in schema model signature

Open fazeelghafoor opened this issue 1 year ago • 3 comments
trafficstars

Fixes #1153 Add support for union type field in model schema

fazeelghafoor avatar Jul 29 '24 00:07 fazeelghafoor

@vitalik can you please review and let me know if anything needs to be modified. I think this is a partial fix to #1153 but I felt like at least add support for UnionTypes.

fazeelghafoor avatar Jul 29 '24 00:07 fazeelghafoor

Could you also add some unit tests for this ?

vitalik avatar Aug 10 '24 17:08 vitalik

@fazeelghafoor Thanks for this fix! Any chance to see the extra coverage on this? It's a pity this fix is stuck and it's really important imho.

Mapiarz avatar Jan 08 '25 11:01 Mapiarz

I tried to pick this up in https://github.com/vitalik/django-ninja/pull/1512

dan-blanchard avatar Jul 22 '25 15:07 dan-blanchard