grive2 icon indicating copy to clipboard operation
grive2 copied to clipboard

Published 20 hours ago • verified publisher icon vitalif

Add 30 second timeout to CurlAgent

Open Tatsh opened this issue 5 years ago • 3 comments

Resolves #306

Tatsh avatar Feb 19 '20 08:02 Tatsh

That would also timeout when syncing large files, am I right?

Heiko-L avatar Oct 05 '20 09:10 Heiko-L

I am not sure what the behaviour is now since I haven't had corrupted files transfer with this patch. I've transferred multi-GB files with this patch enabled.

I'll have to check again on my machine with a large file.

Tatsh avatar Oct 05 '20 09:10 Tatsh

Ran my patched version (built locally) with a 26.3 GiB file and it works. This took much longer than 30 seconds to upload. I verified the checksums of the file after re-downloading it from Drive via web browser.

The issue I was having before was that on macOS it would hang forever if anything went wrong with the connection, which was bad for timed jobs. This solved the issue. But now on macOS the #307 PR code should be used instead.

Tatsh avatar Oct 05 '20 11:10 Tatsh