visualization-tool icon indicating copy to clipboard operation
visualization-tool copied to clipboard
verified publisher icon visualize-admin

added custom color palette e2e tests

Open noahonyejese opened this issue 10 months ago • 8 comments

This PR adds an e2e test for custom color palettes on the profile page.

  • [x] Add a CHANGELOG entry

noahonyejese avatar Feb 19 '25 11:02 noahonyejese

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 0:22am

vercel[bot] avatar Feb 19 '25 11:02 vercel[bot]

@bprusinowski not sure why one of the tests is failing - do you maybe know?

noahonyejese avatar Feb 20 '25 10:02 noahonyejese

@noahonyejese I checked the blob report from the failed test, and it looks like we have a "Error: locator.isVisible: Error: strict mode violation: getByText('Categorical Palette') resolved to 2 elements" error.

Looking at Argos screenshot, in fact there are two palette names that contain this string – I think you'd need to try to match by exact text, not only by checking if an element "contains text"?

bprusinowski avatar Feb 20 '25 10:02 bprusinowski

@noahonyejese I checked the blob report from the failed test, and it looks like we have a "Error: locator.isVisible: Error: strict mode violation: getByText('Categorical Palette') resolved to 2 elements" error.

Looking at Argos screenshot, in fact there are two palette names that contain this string – I think you'd need to try to match by exact text, not only by checking if an element "contains text"?

Not sure because it was working on local

noahonyejese avatar Feb 20 '25 12:02 noahonyejese

@noahonyejese yes, but here the user had a TEST CATEGORICAL PALETTE added, coming from a database, that you probably didn't have on local 🤔

bprusinowski avatar Feb 20 '25 12:02 bprusinowski

@noahonyejese yes, but here the user had a TEST CATEGORICAL PALETTE added, coming from a database, that you probably didn't have on local 🤔

I mean adjusted it now it should use the approach you mentioned but it still doesn't seem to work - I will get back to this PR once completing the higher priority stuff. @bprusinowski

noahonyejese avatar Feb 20 '25 12:02 noahonyejese

@bprusinowski where can I get the blob report?

noahonyejese avatar Feb 26 '25 12:02 noahonyejese

@noahonyejese it looks like something's still off with setting the custom color palettes in end-to-end tests, see the screenshot of failed action there: https://app.argos-ci.com/interactive-things/visualization-tool/builds/452/140680285

It looks like a palette with this name already exists 🤔

bprusinowski avatar Feb 27 '25 10:02 bprusinowski