visualization-tool icon indicating copy to clipboard operation
visualization-tool copied to clipboard

useSyncInteractiveFilters problem

Open ptbrowne opened this issue 1 year ago • 0 comments

We talked briefly with Bartosz about the code being hard to work with in visualize. The useSyncInteractiveFilters hook is a good candidate for possible refactor, and to see what could be holistic improvements to the architecture

  • we cannot audit it, it affects the state but it is not visible
  • should we have "middlewares" on the store ?
  • adding dataFilters, we did not know we needed to add them to useQueryFilters and useSyncInteractiveFilters ?
    • how we could encode this in a way that we can audit it ?
    • Having a filters type, we add dashbaordFilters to it, then we need to exhaustively check for it ?
  • behaviors that is turned on and off in components
  • sync dispatcher, is it really a constraint, could we remove it ?

Issue to be completed and improved.

ptbrowne avatar Jul 31 '24 14:07 ptbrowne