visualization-tool icon indicating copy to clipboard operation
visualization-tool copied to clipboard

Implementation: Combining Multiple Cubes (1. Iteration)

Open sosiology opened this issue 1 year ago • 3 comments

Description Implementation of the UI to enable the merging of data sets in a diagram. This first iteration focuses on merging cubes based on a common temporal dimension. The implementation is based on the design delivered at the end of Sprint 5.5.

Link to Design https://www.figma.com/proto/Hn9wvuEYLUmdJtg4KwZYUx/visualize.admin.ch---design?page-id=904%3A81373&type=design&node-id=3030-242594&viewport=131%2C1040%2C0.08&t=Q4T56Qxo1LTUc7nK-1&scaling=min-zoom&starting-point-node-id=904%3A81378&show-proto-sidebar=1

DoD As a user, I can select a dataset, add another one and create a chart based on the temporal dimension and then publish it.

  • Can search for compatible datasets
  • Can select another dataset
  • Can see cube information for all cubes in metadata panel ("general")
  • Can see dimensions for all cubes grouped by cube in metadata panel ("data")

Assumption/Risks The performance of the editor mode could be reduced due to loading multiple filters.

sosiology avatar Feb 26 '24 08:02 sosiology

@ptbrowne Initial Feedback after initially testing on TEST with the flag ?flag__add-dataset=true

When adding a data set, and there are no matching results, the UI shows "No results" even when searching using the search field, no results are found. I find this confusing, becuase i dont fully understand what I should do. I think we could counter this by having a better message e.g No datasets with shared dimensions found or something similar

Image

When creating a chart with 2 data sets (Bathing Water quality and Heavy Metal Soil Contamination) the chart is not rendered correctily, There is no x-axis label and when hovering near the blue bar a date is shown outside the chart

Image

https://test.visualize.admin.ch/en/v/6RDCv0hC9pWM?dataSource=Prod

sosiology avatar Mar 14 '24 08:03 sosiology

Thanks @ptbrowne. Looks great already. Few little things that I found:

  • Please shorten the Search button next to the search field to "Search" (since the headline was already pointing out to look for a dataset I don't think it's necessary at this point.

Image

  • Please also have a medium size button for this case since it's better aligned with the search field.

  • I guess the adaptation of the new legend might follow in the next sprint? Image

  • When deleting one dataset, the second dataset also disappears: Image

  • y-axis dimension selection: the combination of datasets that I tested gave me a choice to select "Not rounded value" as a dimension. To me that's not very clear to understand. I saw that it is explained in the meta data panel, but I guess a tooltip would help here when choosing the dimension. Image Image Image

  • After clicking in the metadata panel on the joined dimension that is listed per dataset, I think it would be helpful to get a detail that listed the whole joined dimension (from both datasets), like this design example.

KerstinFaye avatar Mar 15 '24 10:03 KerstinFaye

Thanks Kerstin, I put the improvements on two separate issues, smaller things directly in the part 2 of Combining multiple cubes, and the part on the legend that is a bit bigger on a separate issues.

ptbrowne avatar Apr 10 '24 08:04 ptbrowne