visual-framework
Update colours of VF typography
From the typography review, some VF typography elements were found to have different colours in the HTML examples from how it should be defined.
Task
- [ ] Remove the inverted colour on 1 Display variant
- [ ] Update the colour of "3 Regular variant", "4 Small variant", and "5 Extra Small variant" of texts, from #373A36 to the primary text colour #1a1c1a
@Adedoyinebi to check if these are still valid after implementing the changes in #1946
1.Removing inverted heading - are we sure we want to remove it? We are still using it on the VF site. But it does seem like it should be renamed and moved to a seperate variant. 2. Correcting variant colours: Bhushan has helped me find the correct file, however changing it will impact several other components. Not exactly sure how to proceed on this one
- Based on the discussion in the Typography proposal review meeting on Monday 13th May and after investigating best practices, we agreed to update the colour of text variants from the secondary text colour #373A36 to the primary text colour #1A1C1A to ensure consistency of the typography examples.
- The inverted vf-heading (1 Display variant) should be removed and replaced with the “Heading level 1” based on the typography proposal for headings
Useful links:
- Simplifying Typography in the Visual framework - Presentation slides
- Mockups showing updated design and documentation of:
@bhushan-ebi A follow up task has been created for the implementation of the proposed updates - Implementation of updated vf-typography colours in the examples #2042