vis-timeline icon indicating copy to clipboard operation
vis-timeline copied to clipboard

fix(item-update): visibility of range spanning items not always correct

Open ChristianKrebel opened this issue 1 year ago • 1 comments

Items starting before the visible range and ending after it were not always shown if zoomed in too much because of the binary search used for it. I tried to fix the conditions but I could not get it to work with a binary search (maybe someone has a better way?). Also, different approaches like spatial index logic fixed the problem but did not improve performance. So I kept it simple and removed the binary search case for items that have an end time and always brute force check them for visibility. This may worsen performance when having many items with end times but in my manual testing (private repo) it is not performant either way.

Question: Should we make this fix optional per config because it may have a bigger impact?

Module: timeline/component/group

Fixes #1657

ChristianKrebel avatar Dec 12 '24 12:12 ChristianKrebel

@ChristianKrebel Thanks for looking into this and providing a fix!

I have not really tested this and it also might introduce a lower performance but this works should not be ignored. I think we should merge this!

mojoaxel avatar Dec 03 '25 10:12 mojoaxel