angular-visjs icon indicating copy to clipboard operation
angular-visjs copied to clipboard

Not working with up-to-date versions of vis

Open lbthomsen opened this issue 8 years ago • 9 comments

In the bower.json 4.2.0 is specified, but the one included in the bower_components folder is actually 3.12. It works with 3.12 but if using 4.2.0 (or the latest 4.15) the chart does not show.

lbthomsen avatar Feb 15 '16 03:02 lbthomsen

Strange - I'm actually using the latest Vis from a few weeks ago in my project. Can you provide more information.

cdjackson avatar Feb 15 '16 07:02 cdjackson

Well - simple steps to show the issue:

  1. Do a fresh clone: git clone https://github.com/visjs/angular-visjs
  2. Open index.html in browser - working!
  3. Do: bower update
  4. Open index.html - not working!

The bower dependency is on vis 4.2.0 but the vis version in the repo is 3.12.0.

I have tried both 4.2.0 and latest 4.15.0 and I simply can't make it work with newer versions than 3.12.0.

I am pretty sure this is a minor issue but I just haven't been able to figure out what is the cause.

lbthomsen avatar Feb 16 '16 03:02 lbthomsen

Ok - I dug into this a bit further. The 4 steps mentioned in the previous post are still valid - the example asis will only work with the old 3.12.0 vis. However, that is because of the option: " showCustomTime: true," in the app.js. Removing that and the example work up to [email protected]. BUT - vis @4.13 and [email protected] still fails.

lbthomsen avatar Feb 16 '16 07:02 lbthomsen

I have long been ignoring the requirement of vis 4.2.0 without problems. For me it stopped working with 4.13, and continues to not work up to 4.15. I deleted my own css-file, to no avail. Not working means:

  • The timeline is invisible.
  • The data is loaded into the dom.
  • The outer vis-timeline tag has full width but a height of only 20px, and it overlaps upwards into the previous elements, even though it doesn't seem to have any css attributes, like location or top. vis-timeline
  • It's 1st child div which contains everything is also full width but its height is only 2px. div
  • The 3 vis-background children are all 0x0 big, so is vis-center, but it has a 1px border.
  • vis-left is 38x61

Btw. my Linux and hence Firefox are using Esperanto. I hope you can understand the screenshots anyway, otherwise http://translate.google.com/#eo/en/ is your friend ;-)

daniel-pfeiffer avatar Mar 02 '16 12:03 daniel-pfeiffer

It turns out what I say may be a Vis issue: https://github.com/almende/vis/issues/1697

daniel-pfeiffer avatar Mar 03 '16 09:03 daniel-pfeiffer

As requested by Jos in the above vis issue, I created: http://jsbin.com/kotenu/edit?html,js,output If you change it to load vis 4.12 you see a timeline.

daniel-pfeiffer avatar Mar 10 '16 11:03 daniel-pfeiffer

I confirm this to be fixed in 4.16.0 :+1:

daniel-pfeiffer avatar Apr 07 '16 17:04 daniel-pfeiffer

@cdjackson it would be great if you could update the dependency to the latest version of vis.js (4.16.1 at this moment)

josdejong avatar May 03 '16 09:05 josdejong

Is anyone still having problems with this?

amar0k avatar Dec 01 '16 09:12 amar0k