visit icon indicating copy to clipboard operation
visit copied to clipboard

Support unicode chars in annotations

Open markcmiller86 opened this issue 8 months ago • 7 comments

Description

Resolves #20350

Type of change

  • ~~[ ] Bug fix~~
  • [x] New feature~~
  • ~~[ ] Documentation update~~
  • ~~[ ] Other~~

How Has This Been Tested?

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • [ ] I have commented my code where applicable.~~
  • [ ] I have updated the release notes.~~
  • [ ] I have made corresponding changes to the documentation.~~
  • [ ] I have added debugging support to my changes.~~
  • [ ] I have added tests that prove my fix is effective or that my feature works.~~
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.~~
  • [ ] I have added new baselines for any new tests to the repo.~~
  • [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

markcmiller86 avatar Apr 11 '25 20:04 markcmiller86

@biagas and/or @JustinPrivitera if you can take a brief look and lemme know what you think so far, that would be great. I am deciding what to do about 3D axes because they have a lot of custom coding.

markcmiller86 avatar Apr 11 '25 20:04 markcmiller86

Sorry, I misclicked and merged develop into this branch. Hope that's ok.

JustinPrivitera avatar Apr 18 '25 19:04 JustinPrivitera

Ok, I finally have a viable path for unicode in the axes titles...

https://github.com/user-attachments/assets/e7447776-4204-4338-8469-6ad01d821ca9

markcmiller86 avatar May 06 '25 23:05 markcmiller86

Unicode characters in file path names...

Current VisIt

Screenshot 2025-05-07 at 6 36 23 PM

This Pull Request

Screenshot 2025-05-07 at 6 37 33 PM

markcmiller86 avatar May 08 '25 01:05 markcmiller86

Hi @markcmiller86 ! What's the status of this feature? Some of our folks are quite interested in it. Thanks!

marcdurant avatar Nov 04 '25 17:11 marcdurant

@marcdurant apologies that I have let this languish. I worked through a lot of issues but only for 2D annotations. When I went to tackle 3D annotations, I ran into a number of snags that I was working through. The relevant VTK 9.5 objects were not working with VisIt's rendering modality and never actually appearing in a VisIt window. Though, the very same objects in a stand-alone VTK app worked fine. In addition, I've only recently re-activated the mac development platform that I was originally doing this work on and my attentions have been on getting a solid, new release of Silo out. I expect to be able to return to this in another month, maybe a tad sooner.

markcmiller86 avatar Nov 04 '25 18:11 markcmiller86

@markcmiller86 Thanks for the update. Our specific use case is using Expressions to create new Curve variables, and we'd like to be able to label the plot in a way that more cleanly expresses the underlying Expression.

marcdurant avatar Nov 05 '25 16:11 marcdurant