visit icon indicating copy to clipboard operation
visit copied to clipboard

Patch application logic should not predicate on compiler name

Open markcmiller86 opened this issue 7 months ago • 4 comments

Describe the bug

We have a couple of cases where the logic to apply a patch is predicated on the compiler name.

https://github.com/visit-dav/visit/blob/27e2fd6d14d20f88f1a6df0183f3ff4e2ea3f868/src/tools/dev/scripts/bv_support/bv_qt.sh#L266-L267

https://github.com/visit-dav/visit/blob/27e2fd6d14d20f88f1a6df0183f3ff4e2ea3f868/src/tools/dev/scripts/bv_support/bv_xdmf.sh#L244-L245

I believe these are the only places build_visit where a patch is predicated on a compiler name.

The challenge is, we don't know our customer's compiler names. For example a user had the name gcc-12 for their compiler and it failed to trigger the patch as a result.

Unless a patch is to work-around an actual bug in a compiler, we should probably never predicate a patch on a compiler (name or version). In theory, patches are to fix bad application code, not to work-around or otherwise address an issue with a compiler and the patch should work for all compilers or, at the very least, all newer compilers than we typically build VisIt with.

markcmiller86 avatar Jul 23 '24 21:07 markcmiller86