visit icon indicating copy to clipboard operation
visit copied to clipboard

Published 20 hours ago • verified publisher icon visit-dav

Bug in avtZoneTypeLabel expression

Open markcmiller86 opened this issue 9 months ago • 1 comments

I just noticed a bug on line 100 for the default value for the avtZoneTypeLabelExpression.C...

https://github.com/visit-dav/visit/blob/4030be1dca2e05bd1a6968e4645339af8ca61e17/src/avt/Expressions/General/avtZoneTypeLabelExpression.C#L99-L110

The SET_VAL macro is using CPP # stringizing operator and will stringize " ? " to a string of 6 chars which will include the beginning and ending double quote chars. Now, long ago, the val array was set to 8 chars so we don't have overwrite issues (but maybe we did before and that is why it was set to 8?). But, the assoc. VTK array is assuming just 3 chars so we'll only see " ? in the output.

The correct thing is to do SET_VAL( ? ) but I worry about some compilers having trouble with the bare ?. So maybe a better thing is SET_VAL(unk) for unknown or maybe SET_VAL(_?_).

markcmiller86 avatar May 16 '24 22:05 markcmiller86