visit icon indicating copy to clipboard operation
visit copied to clipboard

Published 20 hours ago • verified publisher icon visit-dav

HostProfile Window's QLineEdit widgets emit signals with every keypress

Open biagas opened this issue 1 year ago • 0 comments

Describe the bug

While digging into #18518, I noticed that the QLineEdit widgets for fields like hostName, hostNickName etc, emit their signals with every keypress.

This is due to use of 'textChanged' signal. 'editingFinished' is a better signal, it is emitted when return/enter is pressed or the widget loses focus.

All the line edit widgets in the window should be updated to use editingFinished. The only case where it wouldn't be sufficient is if the widget also has an input Validator attached to it. (I don't think any of them do).

Should all our windows be audited for use of 'textChanged' signal?

Desktop

  • OS and version: all
  • VisIt Version: 3.3 dev
  • Server info (if applicable):

biagas avatar Mar 16 '23 21:03 biagas