uikit icon indicating copy to clipboard operation
uikit copied to clipboard

Overlay transparency for IE8

Open aseemk opened this issue 13 years ago • 2 comments

Hey, just wondering, any reason you used opacity: 1 and background: rgba(0,0,0,.75) in overlay.css instead of a solid black background and 0.75 opacity? Adding filter: alpha(opacity=75) would allow it to then work in IE8 with no seeming downside for modern browsers.

aseemk avatar Feb 23 '12 00:02 aseemk

no specific reason, I'd be fine with changing that. I'm ok with bits and pieces to support >IE8 and friends, just nothing huge and unwieldy

tj avatar Feb 23 '12 00:02 tj

Great. The change was simple:

#overlay {
   position: fixed;
   top: 0;
   left: 0;
-  opacity: 1;
+  opacity: 0.75;
+  filter: alpha(opacity=75);
   width: 100%;
   height: 100%;
-  background: rgba(0,0,0,.75);
+  background: black;
   transition: opacity 300ms;
   z-index: 500;
 }

aseemk avatar Feb 23 '12 00:02 aseemk