page.js icon indicating copy to clipboard operation
page.js copied to clipboard

Setting opts.window should also update isLocation global variable

Open joshgillies opened this issue 6 years ago • 1 comments

I'm currently playing around with page.js in a Worker context, and as a result of that environment having no native window object, etc I'm passing my own via page.setup({ window: {...} }) - however when it comes to initiating a route we get errors because isLocation is not set.

Would it be possible to update the isLocation variable based on the input object from opts.window?

joshgillies avatar Mar 15 '18 05:03 joshgillies

Yup! PR welcome here.

matthewp avatar Mar 15 '18 12:03 matthewp