Charlie Li

Results 15 comments of Charlie Li

As for package detection itself, setuptools does (or at least did) consider `chirp.share` a package implicitly, but of course explicit is always better than implicit.

That's not an error, but a warning. And yes PEP-517 compliance is next on the list. Until then, setuptools can theoretically be pinned to 58, which is the last version...

On second look, both of these commits are wrong. The `importlib_resources` package has to be used for Python < 3.10, not only for the new-style `files()` and `as_files()` API introduced...

> Yes. But it skips share and stock_configs (unless there is the `__init__.py` file in the directory) If that was the case, I would not have had implemented this the...

> Seems there is no branch `py3` for this repo and the above instructions call out to checkout that branch? > > `fatal: 'origin/py3' is not a commit and a...