python-midi icon indicating copy to clipboard operation
python-midi copied to clipboard

Python 3 compatibility

Open florianfesti opened this issue 8 years ago • 3 comments

As promised in #35 here a set of patches that make the master branch (more) compatible with Python 3. As I am not using the sequencer there may still be issues with Python3 left. In general the changes are supposed to keep the code working with Python >=2.6 while also making it run with Python 3.

This patch set does not port all changes that have been made to the features/Python3 branch. This patch set breaks the compatibility of the functions in src/util.py basically assuming they are private.

florianfesti avatar Jan 12 '17 17:01 florianfesti

The metaclass patch uses the "future" module. This is what trips up the test suite. If adding the external dependency is unacceptable it is possible just just copy the function in or write something similar.

florianfesti avatar Jan 12 '17 23:01 florianfesti

Try to build again with this pull request, and works great with python3 without this error, ever again:

from containers import *
ImportError: No module named 'containers'

Applaud :clap:

hiepph avatar Feb 21 '17 23:02 hiepph

I've attempted to complete this work in #130.

mgedmin avatar Oct 11 '17 10:10 mgedmin