battlenet
battlenet copied to clipboard
vishnevskiy
Hello? What's the status of this?
The version of this project on PyPi is three years old. #23 was opened a year and a half ago to update it, and hasn't even been commented on. There are a bunch of open pull requests with little to no activity.
I need something like this for a project of mine, and more importantly, I need something that works with Python 3.
Is it worth it for me to open a pull request? @vishnevskiy, do you have interest in continuing development on this? If not, would you consider letting someone else take over the project here and on PyPi? If no to both, would you mind if I forked this, renamed it, merged some of these outstanding PRs, and uploaded that to pypi?
I don't have time currently to keep it updated but I added you as a collaborator so feel free to put it in shape and I will happily push it to PyPi.
@vishnevskiy what is the current status of the tests? I'll admit I'm not really familiar with unittest, I've always used pytest (or nose on some older projects) but when I run python setup.py test I'm seeing a handful of failures, and the vast majority of tests getting ERROR - perhaps because I don't have an API key, and apparently can't get one?
I think I may have bitten off more than I can handle with the python3 work. On a related note, would there be any concern about breaking 2.5 compatibility?
I am guessing the tests are failing because some of those characters that were used as tests no longer exist.
You are free to use pytest (that is what I normally use now).
Python 2.7+ is an okay requirement with me.