battlenet icon indicating copy to clipboard operation
battlenet copied to clipboard

Test failure in test_character.py: Mismatching achievement dates?

Open paca-project opened this issue 13 years ago • 2 comments

Test failure in test_character.py: Mismatching achievement dates?

File "test_character.py", line 104, in test_achievements self.assertEqual(character.achievements[513], datetime.datetime(2011, 1, 25, 12, 22, 8)) AssertionError: datetime.datetime(2011, 1, 25, 15, 22, 8) != datetime.datetime(2011, 1, 25, 12, 22, 8)

paca-project avatar Jul 24 '11 22:07 paca-project

According to the comments by Crote in the following thread this is a bug in the test case, not the library: https://github.com/vishnevskiy/battlenet/commit/5394d648c4562a711f21720499fb12ebfaf2de1d

Perhaps the test case needs to adjust for varying time zones (convert everything to GMT?) before comparing?

paca-project avatar Aug 14 '11 05:08 paca-project

As stated by http://www.wowpedia.org/Server:Nazjatar_US , the server used runs in the Pacific time zone. The -7h offset in the Armory timestamp, which happens to be in GMT, fits in nicely with the -7 offset for PDT.

Crote avatar Aug 14 '11 07:08 Crote