ElixirSublime icon indicating copy to clipboard operation
ElixirSublime copied to clipboard

Breaks shift+click for selection

Open pfac opened this issue 9 years ago • 63 comments

Not sure even how to try and help with this, but installing this package disables the default selection behaviour of shift+click.

Using sublime text 3, build 3065.

pfac avatar Mar 04 '15 14:03 pfac

Observed on ST 3083 as well, disabling ElixirSublime is the only "workaround" I've been able to find. Log output is:

Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 556, in run_
    return self.run(edit)
  File "/Users/yurigadow/Library/Application Support/Sublime Text 3/Packages/ElixirSublime/elixir_sublime.py", line 218, in run
    if session.send('GOTO', selection):
  File "/Users/yurigadow/Library/Application Support/Sublime Text 3/Packages/ElixirSublime/elixir_sublime.py", line 189, in send
    self.socket.send(str.encode(cmd))
AttributeError: 'NoneType' object has no attribute 'send'

ylg avatar Apr 15 '15 03:04 ylg

+1, this is frustrating. I use shift-click for selection all the time and couldn't figure out why it was broken until I tried uninstalling packages one by one. I think this plugin should merely provide the "elixir_goto_definition" command without forcing a particular shortcut, then tell people how to make their own keyboard shortcut to it in the README.

jamesmacaulay avatar May 16 '15 15:05 jamesmacaulay

+1, uninstalled for this reason :(

YayC avatar Jun 11 '15 17:06 YayC

+1, Uninstalled for the same reason...please fix this one!

onlydole avatar Jul 02 '15 00:07 onlydole

+1 This has been a problem for me since I installed it back in December. I also vote for @jamesmacaulay's solution to this problem. It could conflict with other shortcuts, and I'd also like to pick my own shortcuts.

fnky avatar Jul 15 '15 05:07 fnky

Actually I got this fixed by creating a Default (OSX).sublime-mousemap—where (OSX) would be (Linux) for Linux and (Windows) for Windows—in <path to Sublime configuration>/Packages/User.

You can find your Sublime configuration directory by going in Preferences > Browse Packages... and in the User directory.

[
  {
    "button": "button1",
    "modifiers": ["alt"],
    "press_command": "drag_select",
    "command": "elixir_goto_definition"
  },
  {
    "button": "button1",
    "modifiers": ["shift"],
    "press_command": "drag_select",
    "press_args": {"extend": true}
  }
]

This will overwrite ElixirSublime's default mouse mapping configuration.

You can set the modifiers to anything you want. I chose alt. If you then hold your modifier key and click on a definition, it would go to the Elixir documentation for that definition.

fnky avatar Jul 15 '15 06:07 fnky

@fnky Thank you! That works for me too.

dsander avatar Jul 19 '15 12:07 dsander

+1

@vishnevskiy any plans to change Shift+Click to something that doesn't conflict with standard selection behavior? Or at least maybe there is a way to scope this only to Elixir source files?

frantic avatar Sep 17 '15 09:09 frantic

+1, thought I was going mad!

tomduncalf avatar Nov 24 '15 15:11 tomduncalf

:+1:

murphyslaw avatar Dec 12 '15 08:12 murphyslaw

:+1: Could not figure this out for the life of me. I thought I messed up some setting on my personal computer and I knew that would've been finding a needle in a haystack and I just couldn't be bothered. The google'ing was tough, I hope others find this easily. Shift+Click is so useful. I'm surprised they changed that behaviour, usually it's command+click or alt+click for function/method info

matrinox avatar Jan 24 '16 09:01 matrinox

+1

rhapsodyv avatar Jan 28 '16 13:01 rhapsodyv

+1

rustyfausak avatar Feb 01 '16 16:02 rustyfausak

+1 Issue still present with Sublime Text 3 - build 3103, and version 1.0.4 of the plugin.

tompave avatar Feb 11 '16 15:02 tompave

@tompave I have the exact same version for both and the issue's been fixed. I added a file named ElixirSublime (User).sublime-mousemap to: ~/Library/Application\ Support/Sublime\ Text 3/Packages/User and added the above settings. Try that out

matrinox avatar Feb 11 '16 20:02 matrinox

The worst part of this mousemap is it's not even scoped to Elixir, so it breaks shift-clicking for other languages too.

I'm just deleting ElixirSublime/Default (OSX).sublime-mousemap.

nathany avatar Feb 11 '16 20:02 nathany

+1

adoyle-h avatar Feb 21 '16 12:02 adoyle-h

+1, uninstalled for this reason

thousandsofthem avatar Feb 22 '16 18:02 thousandsofthem

+1 @fnky - thank you

TimHeckel avatar Feb 25 '16 16:02 TimHeckel

+1 Incredibly annoying. thanks @fnky

TJKresch avatar Mar 16 '16 03:03 TJKresch

It does not work on my Sublime (build 3103). Any idea why? @fnky

xuanchien avatar Mar 25 '16 00:03 xuanchien

+1. This is beyond frustrating. Also deleted ElixirSublime/Default (OSX).sublime-mousemap.

nighthawk avatar May 10 '16 22:05 nighthawk

+1

joaquimadraz avatar Jun 02 '16 09:06 joaquimadraz

Still broken

sergiotapia avatar Aug 06 '16 04:08 sergiotapia

@fnky thank you so much, that was a huge help - that was driving me fucking crazy

andfaulkner avatar Aug 22 '16 22:08 andfaulkner

+1

mcelaney avatar Aug 29 '16 19:08 mcelaney

+1

lrascao avatar Sep 11 '16 15:09 lrascao

+1

hsmack avatar Nov 03 '16 22:11 hsmack

👍

konsti avatar Nov 06 '16 13:11 konsti

+1

stephenkoo avatar Dec 01 '16 03:12 stephenkoo

+1

mwjaco avatar Dec 18 '16 23:12 mwjaco

This was driving me mad. Thanks for pointing out this issue.

ghost avatar Dec 20 '16 19:12 ghost

+1

laszlokorte avatar Jan 02 '17 21:01 laszlokorte

+1

fulgorek avatar Jan 06 '17 18:01 fulgorek

+1

pragmaticivan avatar Jan 13 '17 05:01 pragmaticivan

Just faced the same problem, had to disable the package immediately.

Fire-Dragon-DoL avatar Jan 18 '17 14:01 Fire-Dragon-DoL

+1

on the same ⛵️

jelvin avatar Jan 23 '17 10:01 jelvin

+1

jhammann avatar Feb 15 '17 14:02 jhammann

+1

bastianwegge avatar Feb 27 '17 03:02 bastianwegge

+1

hickscorp avatar Mar 09 '17 10:03 hickscorp

This appears to be fixed in issue #31 (June 2016). It doesn't look like a new version was pushed up to Package Control. A new release to Package Control should allow this to be closed

jaydorsey avatar Mar 13 '17 13:03 jaydorsey

It took a while to figure out what was the problem. Why was the update not pushed though?

okdas avatar Apr 19 '17 01:04 okdas

@vishnevskiy Can you please push an updated version to package control to fix the mouse issue?

jeffdeville avatar May 15 '17 14:05 jeffdeville

+1

Preen avatar May 18 '17 12:05 Preen

+1

bitflorist avatar May 22 '17 14:05 bitflorist

+1

rusterholz avatar Jun 30 '17 17:06 rusterholz

+1

meowsus avatar Jul 24 '17 15:07 meowsus

+1

spnkr avatar Aug 03 '17 06:08 spnkr

+1

warnerandy avatar Aug 15 '17 13:08 warnerandy

Sigh.

mattisx avatar Aug 31 '17 10:08 mattisx

+1 annoyed me for almost one whole year

orzFly avatar Nov 02 '17 13:11 orzFly

+1

fadhlirahim avatar Nov 16 '17 03:11 fadhlirahim

I finally switched to https://github.com/elixir-editors/elixir-tmbundle which does anything I cared about from this package without the "Breaks shift+click for selection" bug.

mcelaney avatar Nov 16 '17 22:11 mcelaney

+1

mezza avatar Nov 25 '17 10:11 mezza

+1

DevL avatar Dec 06 '17 08:12 DevL

Removed for this reason too

fuelxc avatar Dec 14 '17 14:12 fuelxc

+1

netfull95 avatar Feb 23 '18 02:02 netfull95

+1

zombiecong avatar Jun 21 '18 01:06 zombiecong

I use vscode in the meantime ☺️

Von meinem iPhone gesendet

Am 21.06.2018 um 03:29 schrieb zombiecong [email protected]:

+1

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

bitflorist avatar Jun 21 '18 03:06 bitflorist

This is still a problem almost four years since the creation of this issue

divmgl avatar Nov 11 '18 23:11 divmgl

I finally got around to googling what was causing this, and just uninstalled it since I don't use Sublime for Elixir dev anymore :(

pavellishin avatar May 02 '19 14:05 pavellishin

Uninstalled. :(

vukanac avatar Sep 16 '19 12:09 vukanac

Actually I got this fixed by creating a Default (OSX).sublime-mousemap—where (OSX) would be (Linux) for Linux and (Windows) for Windows—in <path to Sublime configuration>/Packages/User.

You can find your Sublime configuration directory by going in Preferences > Browse Packages... and in the User directory.

[
  {
    "button": "button1",
    "modifiers": ["alt"],
    "press_command": "drag_select",
    "command": "elixir_goto_definition"
  },
  {
    "button": "button1",
    "modifiers": ["shift"],
    "press_command": "drag_select",
    "press_args": {"extend": true}
  }
]

This will overwrite ElixirSublime's default mouse mapping configuration.

You can set the modifiers to anything you want. I chose alt. If you then hold your modifier key and click on a definition, it would go to the Elixir documentation for that definition.

That's it, all about the Elixir, :)

hscspring avatar Sep 11 '20 09:09 hscspring