Vishal Sodani

Results 14 comments of Vishal Sodani

@Wulf I would like to work on this task. I have started by adding `Axum` to the enum `BackendFramework` and a main.rs+axum file. But, how do I go about testing...

@wulf Thanks for sharing so many pointers :) This `remove_non_framework_files` helped me immediately.

> I know it was not part of the PR description, but could you add (or update) the following code-samples based on [this example](https://github.com/meilisearch/documentation/blob/master/.code-samples.meilisearch.yaml): > > * get_typo_tolerance_1 > >...

> Hey @vishalsodani thanks for this contribution :) > > Could you look at [the specification](https://github.com/meilisearch/specifications/blob/main/text/0117-typo-tolerance-setting-api.md#31-typotolerance-api-resource-definition)? I think the parameters are optional Can you please review? I have made the...

Hi, I feel there is an issue with this API design. If I tun this test, the test fails ` #[meilisearch_test] async fn test_set_typo_tolerance(client: Client, index: Index) { let typo_tolerance...

> I know it was not part of the PR description, but could you add (or update) the following code-samples based on [this example](https://github.com/meilisearch/documentation/blob/master/.code-samples.meilisearch.yaml): > > * get_typo_tolerance_1 > >...

> Hey @vishalsodani thanks for this contribution :) > > Could you look at [the specification](https://github.com/meilisearch/specifications/blob/main/text/0117-typo-tolerance-setting-api.md#31-typotolerance-api-resource-definition)? I think the parameters are optional I have redesigned the API to use a...

@bidoubiwa Hi, I am done with all the changes. Please review. Thanks!

> * default_one_typo_size ok. Should I also revert the builder pattern? It does not seem that useful now.

> Hey @vishalsodani > Actually, you are right and just raised a bug in Meilisearch haha! See [this spec](https://github.com/meilisearch/specifications/blob/main/text/0117-typo-tolerance-setting-api.md#32222-errors) Great!