luma.gl icon indicating copy to clipboard operation
luma.gl copied to clipboard

Published 20 hours ago • verified publisher icon visgl

Duplicated code between context-features and webgl-info

Open 1chandu opened this issue 5 years ago • 4 comments

/webgl-context/context-features.js and utils/webgl-info.js has duplicated code. Internally platform-defines is using webgl-info.j but we are exporting some methods from context-features.js

Background

To Do List

  • [ ] Add label and assign to milestone
  • [ ] Coding
  • [ ] Doc update
  • [ ] Whats new update
  • [ ] Test

1chandu avatar Nov 29 '18 04:11 1chandu

This is a cleanup task, unless its causing any issues, we should only fix this in 7.1, too late for 7.0.

Moving to 7.1

1chandu avatar Apr 09 '19 17:04 1chandu

@1chandu is this duplicate of #1048?

tsherif avatar Apr 11 '19 16:04 tsherif

Not related to isWebGL

ibgreen avatar Apr 11 '19 16:04 ibgreen

Yeah, not same as #1048 , it refers to other code redundancy.

1chandu avatar Apr 11 '19 16:04 1chandu