luma.gl icon indicating copy to clipboard operation
luma.gl copied to clipboard

Published 20 hours ago • verified publisher icon visgl

Update deps in package.json

Open birkskyum opened this issue 2 years ago • 3 comments

Dependabot only updates the lockfile, so this PR will make the package.json catch up to the latest versions.

birkskyum avatar Jul 11 '22 13:07 birkskyum

@birkskyum Thanks for submitting,

Can you share if there was a specific problem/module that made you open this PR, or just "house cleaning" before you start other work?

Updating all dependencies can lead to surprises and typically requires more testing, which is why we use lock files in the first place.

Then again, it may well be time for an across-the-board upgrade.

ibgreen avatar Jul 11 '22 14:07 ibgreen

I didn't encounter specific issues, so it was mainly because it seemed like an across-the-board upgrade could be relevant.

birkskyum avatar Jul 11 '22 14:07 birkskyum

The newer packages require Node >= 14, which seem like a reasonable requirement at this point (https://nodejs.org/en/about/releases/), so I updated the test matrix.

birkskyum avatar Jul 11 '22 14:07 birkskyum

Didn't merge this in a timely way, and was never able to rebase this unfortunately.

ibgreen avatar Sep 19 '23 19:09 ibgreen