luma.gl icon indicating copy to clipboard operation
luma.gl copied to clipboard

TypeError exception during identifyGPUVendor execution

Open ubnt-norbert opened this issue 5 years ago • 4 comments

Actual Result

When using deck.gl map, sometimes an exception is thrown in our web app, specifically:

TypeError: Cannot read property 'match' of null

From the logs it looks like the root cause is coming from @luma.gl/shadertools/src/utils/webgl-info.js:52.

Expected Result

There shouldn't be an exception thrown. When vendor or renderer is not a string, identifyGPUVendor should return UNKNOWN GPU.

Reproduce Steps

I had no luck reproducing the issue locally, it is only reported by error tracking software in client browsers.

To Do List

  • [ ] Add label and assign to milestone
  • [ ] Coding
  • [ ] Test

ubnt-norbert avatar May 28 '19 07:05 ubnt-norbert

Thank you for the detailed report. This will be easy enough to fix for 7.1.

Out of curiosity, could tell me what OS/browser/GPU you're running this on? That code is assuming support for an extension that's widely but not universally supported, so I'm interested to know what the exceptions are.

tsherif avatar May 28 '19 16:05 tsherif

Sure, I have logs from two users. Unfortunately there aren't much details about the machines and no GPU information is available so it won't be much of a surprise if it's not helpful. Here's what we know:

  1. Browser: Chrome, Version: 74.0.3729 OS: Windows 10, Version: Unknown

  2. Browser: Chrome, Version: 74.0.3729 OS: Mac OS X, Version: 10.14.4 (we can't know for sure whether it's a legitimate Mac or a Hackintosh)

ubnt-norbert avatar May 29 '19 06:05 ubnt-norbert

If it's not too much trouble, could you have them navigate to chrome://gpu and send over the info from that page? GPU and driver info would be in there.

tsherif avatar May 29 '19 16:05 tsherif

Too bad but all I can access are just user IP addresses, no contact information is available, sorry!

ubnt-norbert avatar May 30 '19 06:05 ubnt-norbert