luma.gl icon indicating copy to clipboard operation
luma.gl copied to clipboard

Remove auto-inference of attribute divisor

Open Pessimistress opened this issue 5 years ago • 2 comments

https://github.com/uber/luma.gl/blob/master/modules/webgl/src/classes/program-configuration.js#L108

See https://github.com/uber/deck.gl/pull/2919

Pessimistress avatar Apr 08 '19 21:04 Pessimistress

@Pessimistress This should be an easy fix. Any concerns about breakage elsewhere?

tsherif avatar Apr 11 '19 16:04 tsherif

Worth running luma examples.

Updating title to be more specific: Remove auto-inference of attribute types => Remove auto-inference of attribute divisor.

At this stage I would only remove the divisor inference as it is a heuristic (as opposed to being based on a query of the compiled shader).

ibgreen avatar Apr 11 '19 16:04 ibgreen