TerrainLoader skirting issue

[ibgreen]

There are persistent reports of missing skirts in the geometry generated by TerrainLoader.

Per @igorDykhta investigations, changing face culling addresses these which makes it probably that it is a matter of winding order on some of the 4 skirts.

@chrisgervang @kylebarron @belom88 @dryabinin-actionengine

[ibgreen]

Note that there is a TerrainLoader example in loaders.gl which should make work on this issue quicker.

[belom88]

Winding is not the issue. Nothing changes when I change winding. But I've found mistake in making edges for skirting. It is possible solution. I've created #2045

[ibgreen]

We need to enable culling in the TerrainLoader example. @igorDykhta to confirm.

[chrisgervang]

@belom88 do you have a screenshot or test program I can run to see before/after #2045?

[kylebarron]

Maybe try https://github.com/visgl/loaders.gl/tree/master/examples/experimental/terrain?

[belom88]

I checked https://github.com/visgl/loaders.gl/tree/master/examples/experimental/terrain with viewState:

const INITIAL_VIEW_STATE = {
  latitude: 46.920996601550016,
  longitude: -122.47243068245264,
  zoom: 17.054,
  bearing: -42.66233766233766,
  pitch: 70.55952845590556,
  maxPitch: 89
};

Before: After:

[ibgreen]

Closing due to inactivity