deck.gl icon indicating copy to clipboard operation
deck.gl copied to clipboard

[Bug] DataFilterExtension not working with ScenegraphLayer and IconLayer

Open vsigno opened this issue 1 year ago • 2 comments

Description

It seems that the DataFilterExtension is not working with ScenegraphLayer and IconLayer. It works just fine with GeoJsonLayer.

As soon as the property extensions: [new DataFilterExtension({ categorySize: 1 })], is added to the layer, the layer itself is no longer visible (with no errors in the console). Commenting out this line makes the layer visible again.

I tested using the same dataset for the three layers: ScenegraphLayer, IconLayer, and GeoJsonLayer. Only the last one works as expected. The documentation mentions limitations with some aggregation layers, but I did't find anything about those two layers.

Is this an expected behaviour?

Flavors

  • [ ] Script tag
  • [ ] React
  • [ ] Python/Jupyter notebook
  • [X] MapboxOverlay
  • [ ] GoogleMapsOverlay
  • [ ] CartoLayer
  • [ ] ArcGIS

Expected Behavior

Filter data also on ScenegraphLayer and IconLayer.

Steps to Reproduce

Codepen here https://codepen.io/vsigno/pen/eYaEzwG just uncomment line 35 and the Icon will disappear

Environment

  • Framework version: deck.gl@latest
  • Browser: Edge
  • OS: Win

Logs

No response

vsigno avatar Jun 08 '24 01:06 vsigno

Hi there, I’m sure there are other priorities and more critical issues to address. Just wondering when the pull request for this issue will be merged. Thanks.

vsigno avatar Jun 19 '24 08:06 vsigno

Thanks for this. The IconLayer now works as expected with 9.0.20, however the ScenegraphLayer still has the same issue. I updated the CodePen https://codepen.io/vsigno/pen/eYaEzwG

As above, as soon as the property extensions: [new DataFilterExtension({ categorySize: 1 })] [line 55], is added to the layer, the layer itself is no longer visible (with no errors in the console). Commenting out this line makes the layer visible again.

vsigno avatar Jun 21 '24 09:06 vsigno