deck.gl icon indicating copy to clipboard operation
deck.gl copied to clipboard

Published 20 hours ago • verified publisher icon visgl

SAO

Open yan-map opened this issue 2 years ago • 2 comments

Target Use Case

Hello! I Think ambient occlusion in deck.gl can significantly improve appearance of 3d geometry, such as buildings However, I didn't find any working solution ased on deck.gl or luma.gl

Proposal

Is there any opportunity to implement SAO in deck.gl? Screenshot_52

yan-map avatar Sep 09 '22 18:09 yan-map

Hmm, there was an SSAOPass (ssao.js) in v7 of luma.gl https://github.com/visgl/luma.gl/tree/7.1-release/modules/effects/src/experimental/passes, but I can't find it in the latest luma.gl version.

In v8, maintainers cut out a number of things they didn't feel were supported well enough. This may have been a victim of that cleanup.

I'd love to see it back, but I am Not sure if that module still works as is, or if it also needs the supporting Pass classes.

ibgreen avatar Sep 09 '22 18:09 ibgreen

Thank you for a rapid response! Merging two versions of luma.gl is too tricky for me, but is there any example with SSAOPass working with luma.gl 7.1?

yan-map avatar Sep 10 '22 00:09 yan-map