deck.gl icon indicating copy to clipboard operation
deck.gl copied to clipboard

chore: update caniuse-lite

Open zbigg opened this issue 3 years ago • 2 comments

Background

Running yarn test on clean checkout currently fails in test-browser stage with following error:

browser-driver: Browser Test failed: Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db

(ocular-bootstrap somehow manages to update it locally, but we're left with dirty workspace)

Change List

  • update caniuse-lite in yarn.lock

zbigg avatar Jun 02 '22 13:06 zbigg

We have not checked in the new caniuse version because it somehow changes the render test results -o- But I guess it's ok to update them in a dedicated PR.

You can go to test/render/index.js and uncomment the saveOnFail and saveAs lines, and run test browser-headless locally to overwrite the existing golden images.

Pessimistress avatar Jun 02 '22 16:06 Pessimistress

Ok, thanks. I was just exploring and thought it's minor glitch that everyone somehow ignores. Now i see this problem has deeper roots I know that constantly changing environment is nightmare for stable rendering tests, i'll check if mere update of golden images can help ... and if it's needed at all.

zbigg avatar Jun 02 '22 16:06 zbigg