deck.gl icon indicating copy to clipboard operation
deck.gl copied to clipboard

[Feat] Upgrade All Shaders to GLSL 3.00

Open ilan-gold opened this issue 3 years ago • 1 comments

Target Use Case

I think this is probably a good thing to do on principle. But beyond that, I can describe my use-case: I have a custom hook I would like to register that takes a usampler2D argument. This is not <GLSL 3.00 compatible (to my knowledge) but since the hook is prepended on all shaders, regardless of their version, deck.gl layers whose shaders are not GLSL 3.00 compliant will break.

Proposal

We would upgrade all shaders in the codebase to GLSL 3.00 and then allow luma.gl to do downgrade-transpilation as it usually does anyway for WebGL 1.0.

ilan-gold avatar Apr 15 '22 19:04 ilan-gold

For reference: https://github.com/visgl/luma.gl/discussions/1638 and https://github.com/hms-dbmi/viv/pull/517

ilan-gold avatar Apr 15 '22 19:04 ilan-gold