Dustin Spicuzza
Dustin Spicuzza
Couple things I ran into when baking this: * NetworkTables is actually a bit more involved than I had thought through at first. Likely you'd want to reset the default...
I don't understand why tidy/format are failing here.
PR https://github.com/pypa/gh-action-pypi-publish/pull/186 adds a warning to tell users that reusable workflows don't work. ... why don't they work? Is there a manual workaround using "The Manual Way" referenced at https://docs.pypi.org/trusted-publishers/using-a-publisher/...
While this certainly is an edge case, I hit it too. Yay. > Two packages referring to the same files is at best an unusual situation (I'm close to calling...
> This will only work for shared_ptr. That's already better than it was of course, but I wonder how much confusion and bug reports this might cause ("This (unrelated) thing...
Unfortunately, gil_scoped_acquire is in pybind11.h, so I can't use it here. There's also a note there about how the GIL shouldn't be acquired if the interpreter is shutting down, but...
Regarding grabbing the GIL in the deleter, it appears that the std::function wrapper does this already so it's not without precedent.
I think this is worth doing by default, and I'm -1 on requiring a user to enable it via a tag or other hack. The current behavior of potentially losing...
> This will only work for shared_ptr. That's already better than it was of course, but I wonder how much confusion and bug reports this might cause ("This (unrelated) thing...