systemk
systemk copied to clipboard
virtual-kubelet
warn when unimplemented podspec constructs are seen
Right now there is no good way (except reading the source of pod.go) to know if a specific construct in a podspec is implemented or not. It would be good to log/alert/fail if we see such a construct. This would also make it clear what things are still "to be implemented"
Just record an Event for the Pod. That's the Kubernetes way! VK also does it.Running kubectl describe pod <pod name> will show the events.
Now that we have a k8s client, this should be easier, the only way VK allowed for events was to return an error; we may still want to return an error, alternatively we need to be very clear what returns an error and what returns an event
Yes
On Mon, 28 Dec 2020, 11:45 Pires, [email protected] wrote:
Return errors to whom? VK?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/virtual-kubelet/systemk/issues/29#issuecomment-751669922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACWIW2RXBLWUEIM7V3OKZTSXBOVLANCNFSM4VGXSTAA .
In #65, I'm introducing an event recorder that is passed onto the VK's Pod controller. If desired, we can have the same or similar event recorder in our provider to write events for the Pod being processed.
Something like that makes sense. however it requires for us to know when we see something we can't do or haven't implemented... Which is a lot of work
On Wed, 20 Jan 2021, 21:29 Pires, [email protected] wrote:
In #65 https://github.com/virtual-kubelet/systemk/pull/65, I'm introducing an event recorder that is passed onto the VK's Pod controller. If desired, we can have the same or similar event recorder in our provider to write events for the Pod being processed.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/virtual-kubelet/systemk/issues/29#issuecomment-763912385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACWIW4UVF4LGPR744WLGX3S244JVANCNFSM4VGXSTAA .