virocore
virocore copied to clipboard
Questions around MIT licensing and new React Viro + Viro Core release
- [X] Review the documentation: https://virocore.viromedia.com/
- [X] Search for existing issues: https://github.com/viromedia/virocore/issues
- [X] Use the latest ViroCore release: https://virocore.viromedia.com/docs/releases
- [X] Turn off Instant Run in Android Studio
Environment
N/A, this is a request for information
Description
Hi, I noticed that you've recently MIT licensed your work. That's really cool since we're actually building an application right now that's using your framework. Thank you for doing that. :) This means that I can help you since we're currently working through some issues ourselves. I have a few questions. Some of these are pertinent to React Native and others to the core framework:
- Do you know if you're planning on supporting React Native 0.61? My first attempt at pulling
react-viroover didn't really work. I needed to rebuild the.aaragainst 0.61. - Are license keys no longer required? I noticed in the commit log that it was noted. I was able to regenerate an
.aarof thereact_bridgein the othervirorepository, but the precompiled.so's cause the app to not launch. The reason seems to be because the license key check is still present in the compiled code for viro core. - Do you have plans to post a compiled
.sofor the viro core libraries into the other repository? Failing that, will you provide instructions on how to regenerate the.sofiles ourselves? It's not clear to me right now how I would build it here, and the README notes the missing instructions. :( - Will the license key check endpoint stop responding at some point? If so, when? I was planning on patching back in the license code in my local copy of the React Viro repository, but it occurred to me today that the endpoint may not be there forever. It might be necessary to backport that check removal to prior versions of the library to maintain continuity, though we're ready to upgrade whenever personally.
Again, thank you so much for all your effort and amazing work. I know that you only have posted the source in the past week or so and I'm sure you all are still figuring out how you want this all to work out, so I appreciate any information you can already give.
Thanks again. : )
Reproducible Demo.
N/A, this is a request for information
Hey @amattice-22sq thanks for reaching out.
Are license keys no longer required? / Will the license key check endpoint stop responding at some point?
This is hard to say. The current plan is that any apps built with virocore 1.16 or viroreact 2.16.0 will still require licenses as those older versions perform a license check. Moving forwards, we will be releasing a next version that does not require those checks (eta still to be determined). In addition, if you re-build the open sourced viro framework as it stands now in both virocore and viroreact, no license key check is performed.
We are currently in the process of open-sourcing the viro frame work, and will have build instructions soon, so stay tuned :)