virocore
virocore copied to clipboard
GLTF animations parsing error
- [x] Review the documentation: https://virocore.viromedia.com/
- [x] Search for existing issues: https://github.com/viromedia/virocore/issues
- [x] Use the latest ViroCore release: https://virocore.viromedia.com/docs/releases
- [x] Turn off Instant Run in Android Studio
Environment
Please provide the following information about your environment:
- OS: MacOS 10.14.5
- Version: ViroCore 1.14
- Device(s): Samsung Galaxy S9 Android 8.0.0, One+ 6 Android 9.0.0
Description
We are working with our own GLTF models on an Android app which is unable to parse animations data. The error from ViroCore is
ERROR: [/Users/manish/workspace/ViroRenderer/ViroRenderer/VROGLTFLoader.cpp: processAnimations(), line 429]
ERROR: Error when parsing key frame animations
We have an iOS version of the app using another 3rd party library to load gltf without problem on these models.
Reproducible Demo
We can't share the whole file atm, but we can give the animations
json part. Tell us if these data are not enough to see what we can do. We have few other sample models with animations not parsing.
"animations": [
{
"channels": [
{
"sampler": 0,
"target": {
"node": 1,
"path": "translation"
}
},
{
"sampler": 1,
"target": {
"node": 1,
"path": "scale"
}
},
{
"sampler": 2,
"target": {
"node": 74,
"path": "translation"
}
},
{
"sampler": 3,
"target": {
"node": 75,
"path": "translation"
}
},
{
"sampler": 4,
"target": {
"node": 82,
"path": "translation"
}
},
{
"sampler": 5,
"target": {
"node": 82,
"path": "rotation"
}
},
{
"sampler": 6,
"target": {
"node": 85,
"path": "translation"
}
},
{
"sampler": 7,
"target": {
"node": 85,
"path": "scale"
}
},
{
"sampler": 8,
"target": {
"node": 86,
"path": "translation"
}
},
{
"sampler": 9,
"target": {
"node": 86,
"path": "scale"
}
},
{
"sampler": 10,
"target": {
"node": 87,
"path": "translation"
}
},
{
"sampler": 11,
"target": {
"node": 87,
"path": "scale"
}
},
{
"sampler": 12,
"target": {
"node": 88,
"path": "translation"
}
},
{
"sampler": 13,
"target": {
"node": 88,
"path": "scale"
}
},
{
"sampler": 14,
"target": {
"node": 89,
"path": "translation"
}
},
{
"sampler": 15,
"target": {
"node": 89,
"path": "scale"
}
}
],
"samplers": [
{
"input": 340,
"interpolation": "LINEAR",
"output": 341
},
{
"input": 342,
"interpolation": "LINEAR",
"output": 343
},
{
"input": 344,
"interpolation": "LINEAR",
"output": 345
},
{
"input": 346,
"interpolation": "LINEAR",
"output": 347
},
{
"input": 348,
"interpolation": "LINEAR",
"output": 349
},
{
"input": 350,
"interpolation": "LINEAR",
"output": 351
},
{
"input": 352,
"interpolation": "LINEAR",
"output": 353
},
{
"input": 354,
"interpolation": "LINEAR",
"output": 355
},
{
"input": 356,
"interpolation": "LINEAR",
"output": 357
},
{
"input": 358,
"interpolation": "LINEAR",
"output": 359
},
{
"input": 360,
"interpolation": "LINEAR",
"output": 361
},
{
"input": 362,
"interpolation": "LINEAR",
"output": 363
},
{
"input": 364,
"interpolation": "LINEAR",
"output": 365
},
{
"input": 366,
"interpolation": "LINEAR",
"output": 367
},
{
"input": 368,
"interpolation": "LINEAR",
"output": 369
},
{
"input": 370,
"interpolation": "LINEAR",
"output": 371
}
],
"name": "All Animations"
}
]
If you have an example glTF file that has animations not working, that would help us out a lot in debugging this. It's hard for me to reproduce given only the animation JSON. We're putting out a new release soon with glTF fixes so we'd like to fix this as well. Thanks!
Raj
On Thu, Jun 27, 2019 at 6:15 AM ryancrunchi [email protected] wrote:
- Review the documentation: https://virocore.viromedia.com/
- Search for existing issues: https://github.com/viromedia/virocore/issues
- Use the latest ViroCore release: https://virocore.viromedia.com/docs/releases
- Turn off Instant Run in Android Studio
Environment
Please provide the following information about your environment:
- OS: MacOS 10.14.5
- Version: ViroCore 1.14
- Device(s): Samsung Galaxy S9 Android 8.0.0, One+ 6 Android 9.0.0
Description
We are working with our own GLTF models on an Android app which is unable to parse animations data. The error from ViroCore is
ERROR: [/Users/manish/workspace/ViroRenderer/ViroRenderer/VROGLTFLoader.cpp: processAnimations(), line 429] ERROR: Error when parsing key frame animations
We have an iOS version of the app using another 3rd party library to load gltf without problem on these models. Reproducible Demo
We can't share the whole file atm, but we can give the animations json part. Tell us if these data are not enough to see what we can do. We have few other sample models with animations not parsing.
"animations": [ { "channels": [ { "sampler": 0, "target": { "node": 1, "path": "translation" } }, { "sampler": 1, "target": { "node": 1, "path": "scale" } }, { "sampler": 2, "target": { "node": 74, "path": "translation" } }, { "sampler": 3, "target": { "node": 75, "path": "translation" } }, { "sampler": 4, "target": { "node": 82, "path": "translation" } }, { "sampler": 5, "target": { "node": 82, "path": "rotation" } }, { "sampler": 6, "target": { "node": 85, "path": "translation" } }, { "sampler": 7, "target": { "node": 85, "path": "scale" } }, { "sampler": 8, "target": { "node": 86, "path": "translation" } }, { "sampler": 9, "target": { "node": 86, "path": "scale" } }, { "sampler": 10, "target": { "node": 87, "path": "translation" } }, { "sampler": 11, "target": { "node": 87, "path": "scale" } }, { "sampler": 12, "target": { "node": 88, "path": "translation" } }, { "sampler": 13, "target": { "node": 88, "path": "scale" } }, { "sampler": 14, "target": { "node": 89, "path": "translation" } }, { "sampler": 15, "target": { "node": 89, "path": "scale" } } ], "samplers": [ { "input": 340, "interpolation": "LINEAR", "output": 341 }, { "input": 342, "interpolation": "LINEAR", "output": 343 }, { "input": 344, "interpolation": "LINEAR", "output": 345 }, { "input": 346, "interpolation": "LINEAR", "output": 347 }, { "input": 348, "interpolation": "LINEAR", "output": 349 }, { "input": 350, "interpolation": "LINEAR", "output": 351 }, { "input": 352, "interpolation": "LINEAR", "output": 353 }, { "input": 354, "interpolation": "LINEAR", "output": 355 }, { "input": 356, "interpolation": "LINEAR", "output": 357 }, { "input": 358, "interpolation": "LINEAR", "output": 359 }, { "input": 360, "interpolation": "LINEAR", "output": 361 }, { "input": 362, "interpolation": "LINEAR", "output": 363 }, { "input": 364, "interpolation": "LINEAR", "output": 365 }, { "input": 366, "interpolation": "LINEAR", "output": 367 }, { "input": 368, "interpolation": "LINEAR", "output": 369 }, { "input": 370, "interpolation": "LINEAR", "output": 371 } ], "name": "All Animations" } ]
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viromedia/virocore/issues/295?email_source=notifications&email_token=ADRZL27XGVGQFNPVQRGWDP3P4SHMTA5CNFSM4H32N542YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4BCJCA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRZL23F5BG355PZG6EPWZTP4SHMTANCNFSM4H32N54Q .
You can email the glTF to [email protected], if that's easier.
On Thu, Jun 27, 2019 at 10:42 AM Raj Advani [email protected] wrote:
If you have an example glTF file that has animations not working, that would help us out a lot in debugging this. It's hard for me to reproduce given only the animation JSON. We're putting out a new release soon with glTF fixes so we'd like to fix this as well. Thanks!
Raj
On Thu, Jun 27, 2019 at 6:15 AM ryancrunchi [email protected] wrote:
- Review the documentation: https://virocore.viromedia.com/
- Search for existing issues: https://github.com/viromedia/virocore/issues
- Use the latest ViroCore release: https://virocore.viromedia.com/docs/releases
- Turn off Instant Run in Android Studio
Environment
Please provide the following information about your environment:
- OS: MacOS 10.14.5
- Version: ViroCore 1.14
- Device(s): Samsung Galaxy S9 Android 8.0.0, One+ 6 Android 9.0.0
Description
We are working with our own GLTF models on an Android app which is unable to parse animations data. The error from ViroCore is
ERROR: [/Users/manish/workspace/ViroRenderer/ViroRenderer/VROGLTFLoader.cpp: processAnimations(), line 429] ERROR: Error when parsing key frame animations
We have an iOS version of the app using another 3rd party library to load gltf without problem on these models. Reproducible Demo
We can't share the whole file atm, but we can give the animations json part. Tell us if these data are not enough to see what we can do. We have few other sample models with animations not parsing.
"animations": [ { "channels": [ { "sampler": 0, "target": { "node": 1, "path": "translation" } }, { "sampler": 1, "target": { "node": 1, "path": "scale" } }, { "sampler": 2, "target": { "node": 74, "path": "translation" } }, { "sampler": 3, "target": { "node": 75, "path": "translation" } }, { "sampler": 4, "target": { "node": 82, "path": "translation" } }, { "sampler": 5, "target": { "node": 82, "path": "rotation" } }, { "sampler": 6, "target": { "node": 85, "path": "translation" } }, { "sampler": 7, "target": { "node": 85, "path": "scale" } }, { "sampler": 8, "target": { "node": 86, "path": "translation" } }, { "sampler": 9, "target": { "node": 86, "path": "scale" } }, { "sampler": 10, "target": { "node": 87, "path": "translation" } }, { "sampler": 11, "target": { "node": 87, "path": "scale" } }, { "sampler": 12, "target": { "node": 88, "path": "translation" } }, { "sampler": 13, "target": { "node": 88, "path": "scale" } }, { "sampler": 14, "target": { "node": 89, "path": "translation" } }, { "sampler": 15, "target": { "node": 89, "path": "scale" } } ], "samplers": [ { "input": 340, "interpolation": "LINEAR", "output": 341 }, { "input": 342, "interpolation": "LINEAR", "output": 343 }, { "input": 344, "interpolation": "LINEAR", "output": 345 }, { "input": 346, "interpolation": "LINEAR", "output": 347 }, { "input": 348, "interpolation": "LINEAR", "output": 349 }, { "input": 350, "interpolation": "LINEAR", "output": 351 }, { "input": 352, "interpolation": "LINEAR", "output": 353 }, { "input": 354, "interpolation": "LINEAR", "output": 355 }, { "input": 356, "interpolation": "LINEAR", "output": 357 }, { "input": 358, "interpolation": "LINEAR", "output": 359 }, { "input": 360, "interpolation": "LINEAR", "output": 361 }, { "input": 362, "interpolation": "LINEAR", "output": 363 }, { "input": 364, "interpolation": "LINEAR", "output": 365 }, { "input": 366, "interpolation": "LINEAR", "output": 367 }, { "input": 368, "interpolation": "LINEAR", "output": 369 }, { "input": 370, "interpolation": "LINEAR", "output": 371 } ], "name": "All Animations" } ]
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viromedia/virocore/issues/295?email_source=notifications&email_token=ADRZL27XGVGQFNPVQRGWDP3P4SHMTA5CNFSM4H32N542YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4BCJCA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRZL23F5BG355PZG6EPWZTP4SHMTANCNFSM4H32N54Q .
Hey @ryancrunchi , by any chance do you have that model on you that you could send to us? Much thanks!
Hey @ryancrunchi , we've root caused the issue that was causing the animation mishap - this will be patched in the upcoming release.